CHE-396 Rename perspective and Workspace agent #679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -37,7 +37,7 @@ | |||
| public class Machine { | |||
|
|
|||
| public static final String TERMINAL_REF_KEY = "terminal"; | |||
| public static final String EXTENSIONS_REF_KEY = "extensions"; | |||
| public static final String EXTENSIONS_REF_KEY = "workspace-agent"; | |||
There was a problem hiding this comment.
what about rename EXTENSIONS_REF_KEY to WS_AGENT_REF_KEY?
There was a problem hiding this comment.
Issue describes that
|
+1 |
|
ok |
Signed-off-by: Vitaliy Guliy <vguliy@codenvy.com>
|
LGTM |
vitaliy-guliy
pushed a commit
that referenced
this pull request
Mar 14, 2016
CHE-396 Rename perspective and Workspace agent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_1 Upvote_ Signed-off-by: Vitaliy Guliy vguliy@codenvy.com