CODENVY-191: Add update factory client impl #677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * push refuses to update a remote ref that is not an ancestor of the local ref used to overwrite it. If <code>true</code> | ||
| * disables the check. This can cause the remote repository to lose commits | ||
| */ | ||
| Promise<PushResponse> push(String wsId, |
There was a problem hiding this comment.
please, mark old method as deprecated
There was a problem hiding this comment.
You use only string path from the ProjectConfigDto. So there is no need to pass whole configuration into this method.
There was a problem hiding this comment.
Also it should be fixed over other issue, not related to this, here I only rewrite methods with the promises without changing in the common signature.
|
ok |
| @@ -90,4 +90,7 @@ | |||
| * @return a promise that will provide a list of {@link Factory}s, or rejects with an error | |||
| */ | |||
| Promise<List<Factory>> findFactory(Integer skipCount, Integer maxItems, List<Pair<String, String>> params); | |||
|
|
|||
|
|
|||
| Promise<Factory> updateFactory(String id, Factory factory); | |||
There was a problem hiding this comment.
Javadoc for the api method?
akorneta
force-pushed
the
CODENVY-191
branch
7 times, most recently
from
5ee2677 to
ff31960
Compare
…hub pull request update
akorneta
added a commit
that referenced
this pull request
Mar 15, 2016
CODENVY-191: Add update factory client impl
Katka92
pushed a commit
to Katka92/che
that referenced
this pull request
Jun 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.