Add promise-based methods for GitHub client service #618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please, add javadocs for all added methods in GitHubClientService interface |
|
+1 to add javadocs |
| void createPullRequest(@NotNull String user, @NotNull String repository, @NotNull GitHubPullRequestCreationInput input, | ||
| void createPullRequest(@NotNull String user, | ||
| @NotNull String repository, | ||
| @NotNull GitHubPullRequestCreationInput input, | ||
| @NotNull AsyncRequestCallback<GitHubPullRequest> callback); |
There was a problem hiding this comment.
Why this method changed directly instead of deprecation old method and new method addition just like for other methods you did?
There was a problem hiding this comment.
Here we just fixed the formatting, and do the same things as with other methods (writing new one)
|
ok @vparfonov ? |
| @@ -111,10 +135,21 @@ void commentIssue(@NotNull String user, @NotNull String repository, @NotNull Str | |||
| * the repository name. | |||
| * @param callback | |||
| * callback called when operation is done. | |||
| * @deprecated use {@link #getPullRequests(String, String)} | |||
| */ | |||
| void getPullRequests(@NotNull String owner, @NotNull String repository, @NotNull AsyncRequestCallback<GitHubPullRequestList> callback); | |||
There was a problem hiding this comment.
Add @Deprecated annotation.
|
FIY, provide a little description in future PR's to describe what exactly PR propose to improve or fix. |
|
ok |
mkuznyetsov
force-pushed
the
github-refactor
branch
from
8dea9be to
dfd56e4
Compare
|
ok |
mkuznyetsov
pushed a commit
that referenced
this pull request
Mar 3, 2016
Add promise-based methods for GitHub client service
Katka92
pushed a commit
to Katka92/che
that referenced
this pull request
Jun 27, 2018
Related to issue redhat-developer/rh-che#615 Signed-off-by: David Festal <dfestal@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_1 Upvote_