CHE-201: remove breakpoints in case of absence of linked file #607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tolusha, @vparfonov, @skabashnyuk, @sleshchenko, @vzhukovskii: please, review this request. |
dmytro-ndp
force-pushed
the
CHE-201
branch
2 times, most recently
from
0a65b81 to
11d0cbc
Compare
dmytro-ndp
changed the title
|
+1 |
1 similar comment
|
+1 |
Remove all debugger breakpoints and current execution point in the next cases: case 1: when linked file has been removed from project explorer; case 2: when folder with linked file has been removed from project explorer; case 3: when project with linked file has been removed from project explorer; case 4: when there is no project with linked file after the loading of project explorer. Signed-off-by: Dmytro Nochevnov <dnochevnov@codenvy.com>
| * | ||
| * @param projectTypeId | ||
| * @param debugger | ||
| */ | ||
| public void registeredDebugger(String projectTypeId, Debugger debugger) { | ||
| debuggers.put(projectTypeId, debugger); | ||
| setDebugger(debugger); |
There was a problem hiding this comment.
Not clear for me we have registeredDebugger(String projectTypeId, Debugger debugger) we map debuger to the projectId (it's ok) but set/get debugger not understand
There was a problem hiding this comment.
This part will be rewritten in time of refactoring of DebuggerPresenter (issue https://jira.codenvycorp.com/browse/CHE-492).
There was a problem hiding this comment.
I would like to keep as is. Because right now I am working on refactoring all classed related to debug. So, DebuggerManager will be change significantly
|
ok |
dmytro-ndp
added a commit
that referenced
this pull request
Mar 3, 2016
CHE-201: remove breakpoints in case of absence of linked file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_2 Upvotes_ Remove all debugger breakpoints and current execution point in the next cases:
case 1: when linked file has been removed from project explorer;
case 2: when folder with linked file has been removed from project explorer;
case 3: when project with linked file has been removed from project explorer;
case 4: when there is no project with linked file after the loading of project explorer.
Signed-off-by: Dmytro Nochevnov dnochevnov@codenvy.com