CODENVY-88 Setup new jvm defaults #528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ### Cannot add this in setenv.sh. | ||
| ### We do the port mapping here, and this gets inserted into server.xml when tomcat boots | ||
| export JAVA_OPTS="${JAVA_OPTS} -Dport.http=${CHE_PORT}" | ||
| export JAVA_OPTS="${JAVA_OPTS} -Dport.http=${CHE_PORT} -Dche.home=${CHE_HOME}" | ||
| export SERVER_PORT=${CHE_PORT} | ||
|
|
||
| # Launch the Che application server, passing in command line parameters |
There was a problem hiding this comment.
you changed file permissions of that file. please fix that
There was a problem hiding this comment.
but 100644 → 100755 it is correct permission for .sh
There was a problem hiding this comment.
yeap, didn't noticed. thank you @riuvshin
| <destName>setenv.sh</destName> | ||
| <fileMode>755</fileMode> | ||
| </file> | ||
| <file> |
There was a problem hiding this comment.
Am I correct that after that change setenv.sh from che-lib will be used?
skabashnyuk
force-pushed
the
CODENVY-88
branch
2 times, most recently
from
83da708 to
191b920
Compare
… non-blocking entropy source
skabashnyuk
force-pushed
the
CODENVY-88
branch
from
191b920 to
281a32b
Compare
skabashnyuk
added a commit
that referenced
this pull request
Feb 26, 2016
CODENVY-88 Setup new jvm defaults
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setup jvm defaults and all java options in che.sh.
Used a non-blocking entropy source
Connected
eclipse-che/che-lib#1
#498