Fall back to unix socket on Linux if DOCKER_HOST is malformed #454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -44,7 +44,7 @@ | |||
| /** | |||
| * Default ip of docker host (Linux system). | |||
| */ | |||
| protected static final String DEFAULT_LINUX_DOCKER_HOST_IP = "172.17.42.1"; | |||
| protected static final String DEFAULT_LINUX_DOCKER_HOST_IP = "172.17.42.1"; | |||
|
LGTM |
|
ок |
|
+1 by squashing the two commits |
Signed-off-by: Eugene Ivantsov <eivantsov@codenvy.com>
ghost
force-pushed
the
use_unix_socket
branch
from
31a91c2 to
12a3268
Compare
ghost
pushed a commit
that referenced
this pull request
Feb 22, 2016
Fall back to unix socket on Linux if DOCKER_HOST is malformed
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_1 Upvote_ Use of DEFAULT_DOCKER_MACHINE_URI on Linux makes little sense when DOCKER_HOST is malformed, so to us better to use unix socket in this case.