Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CODENVY-128. Fix configure multimodular project with module without java files. #445

Merged
merged 1 commit into from
Feb 19, 2016

Conversation

RomanNikitenko
Copy link
Member

@RomanNikitenko RomanNikitenko commented Feb 19, 2016

_1 Upvote_

@RomanNikitenko
Copy link
Member Author

@benoitf WDYT?

@benoitf
Copy link
Contributor

benoitf commented Feb 19, 2016

missing signed-off

@benoitf
Copy link
Contributor

benoitf commented Feb 19, 2016

I think some unit tests will also fail

@RomanNikitenko
Copy link
Member Author

@benoitf All tests - success

@RomanNikitenko
Copy link
Member Author

@skabashnyuk WDYT?

@benoitf
Copy link
Contributor

benoitf commented Feb 19, 2016

@RomanNikitenko you're still missing Signed-Off in commit message

@RomanNikitenko
Copy link
Member Author

@benoitf we can merge without Signed-Off in commit message

@benoitf
Copy link
Contributor

benoitf commented Feb 19, 2016

+1

…ava files.

Signed-off-by: Roman Nikitenko <rnikitenko@codenvy.com>
@skabashnyuk
Copy link
Contributor

ok

RomanNikitenko added a commit that referenced this pull request Feb 19, 2016
CODENVY-128. Fix configure multimodular project with module without java files.
@RomanNikitenko RomanNikitenko merged commit ab80c2e into master Feb 19, 2016
@RomanNikitenko RomanNikitenko deleted the CODENVY-128 branch February 19, 2016 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants