IDEX-4228: Fix import project from ssh url #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ok @vparfonov ? |
| String errorMessage = ErrorMessageUtils.getErrorMessage(exception.getCause()); | ||
| if (errorMessage.equals("Unable get private ssh key")) { | ||
| subscriber.onFailure(errorMessage); | ||
| if ("Unable get private ssh key".equals(errorMessage)) { |
There was a problem hiding this comment.
Should be changed to errorCode then it will be done
|
ok |
vinokurig
changed the title
Signed-off-by: Igor Vinokur <ivinokur@codenvy.com>
vinokurig
pushed a commit
that referenced
this pull request
Feb 16, 2016
IDEX-4228: Fix import project from ssh url
Katka92
pushed a commit
to Katka92/che
that referenced
this pull request
Jun 27, 2018
…ching. Reactivating without dashboard build (eclipse-che#318) Signed-off-by: Sun Tan <sutan@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Igor Vinokur ivinokur@codenvy.com
When importing project by ssh url without ssh keys, empty project appears after refreshing the page. Also the error message was ugly.
@skabashnyuk @vparfonov please review