Remove set -o pipefail fron che script #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 26, 2016
Closed
|
it seems description of PR should be updated as it does not only remove pipefail from che.sh script it removes trailing spaces, add some {}, etc |
|
Description says about changing style of variable expansion. |
|
|
|
|
|
Description, not title. It is auto generated from commit. I added 2 last lines to description to commit message. |
garagatyi
force-pushed
the
removePipeFailFromStartScript
branch
from
93d5765 to
00a2d2f
Compare
Use the same style for variable expansion in whole script
|
ok. @vparfonov ? |
|
LGTM. Let's merge it. |
garagatyi
pushed a commit
that referenced
this pull request
Jan 27, 2016
Remove set -o pipefail fron che script
Katka92
pushed a commit
to Katka92/che
that referenced
this pull request
Jun 27, 2018
…se-che#223) This is related to redhat-developer/rh-che#218 Signed-off-by: David Festal <dfestal@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the same style for variable expansion in whole script
In some bash environments
set -o pipefailis illegal and Che can't start in that case.@TylerJewell @vparfonov