CHE-1810 Create JPA based SshDao implementation #1975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| requireNonNull(service); | ||
| try { | ||
| EntityManager manager = managerProvider.get(); | ||
| List<SshPairImpl> resultList = manager.createQuery("SELECT pair " + |
There was a problem hiding this comment.
why do you need result list varialbe?
|
@akorneta @evoevodin ? |
|
Build # 1331 - FAILED Please check console output at http://ci.codenvy-dev.com/jenkins/job/che-pullrequests-build/1331/ to view the results. |
| <dependency> | ||
| <groupId>com.google.inject.extensions</groupId> | ||
| <artifactId>guice-persist</artifactId> | ||
| <scope>compile</scope> |
There was a problem hiding this comment.
Why the compile scope is defined explicitly?
|
ok for me |
| import javax.persistence.Index; | ||
| import javax.persistence.JoinColumn; | ||
| import javax.persistence.ManyToOne; | ||
| import javax.persistence.OneToMany; |
|
Build # 1334 - FAILED Please check console output at http://ci.codenvy-dev.com/jenkins/job/che-pullrequests-build/1334/ to view the results. |
|
LGTM |
|
ok for me |
- Created SshDao on JPA - Added 'owner' to SshPairImpl - Created TCK for JPA and local implementations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds JpaSshDao and TCK to test it, as well as local DAO implementation.
What issues does this PR fix or reference?
CHE-1810
Previous Behavior
LocalSshDao previously stored as map of pairs by owner.
New Behavior
SshImpl now contains field owner. LocalSshDao now stores pairs in list.
Tests written?
Yes
Docs requirements?
No