-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
One AsciiDoc reference file per parameter #19637
Conversation
Can one of the admins verify this patch? |
Please merge the latest master to fix the build check. |
default values in adoc files are prone to become obsolete, this is not safe. It's arguable if these default values are really default, because che-operator/helm might set them to something different with their default installation configuration. |
how are adoc files going to be referenced from che/multiuser.properties ? Is it in the scope of this PR ? |
why is there a script in this PR? My assumption was that the comments would be transferred in one batch, so why we need the script here? What will be the process. |
|
Because it's a draft and I fear the content will get obsolete before we reach consensus. Need to remove it before finalizing. |
I believe we should do it in 2 different PR, change the comments once the documentation has done the transition. I believe we could replace comments by:
|
|
|
Closing, new plan described here: #19630 (comment) |
To feed the discussion in #19630
Now:
che.properties
ormultiuser.properties
.