[Replaces #1885] Launcher: fixed Path problems, splitted in 3 files and added tests #1914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cleaned up syntax so that the variables will work on Windows. Signed-off-by: Mario Loriedo <mloriedo@redhat.com>
Signed-off-by: Mario Loriedo <mloriedo@redhat.com>
|
Ok - +1. Reviews completed in other branch. Thanks, @l0rd for updating here. |
TylerJewell
added
the
kind/bug
ShimonBenYair
pushed a commit
to ShimonBenYair/che
that referenced
this pull request
Aug 4, 2016
…n 3 files and added tests (eclipse-che#1914) * Fix environment variables for CHE_DATA_FOLDER Cleaned up syntax so that the variables will work on Windows. Signed-off-by: Mario Loriedo <mloriedo@redhat.com> * Launcher: fixed Path problems, splitted in 3 files and added tests Signed-off-by: Mario Loriedo <mloriedo@redhat.com> * Launcher tests: added instructions to run bats tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces #1885
What does this PR do?
Add a new function to cleanup paths strings provided by users, splitted the big shell script launcher.sh in 3 different scripts, added some unit tests.
What issues does this PR fix or reference?
Problems with paths provided by users
Previous Behavior
Che failed to store workspace when providing a path with a trailing slash:
-e CHE_STORAGE_FOLDER=/somefolder/New Behavior
CHE_STORAGE_FOLDER and CHE_CONF_FOLDER variables are cleaned up (trailing slashes are removed)
Tests written?
Yes
Docs requirements?
No
Please review Che's Contributing Guide for best practices.
Signed-off-by: Mario Loriedo mloriedo@redhat.com