CHE-1849: Modify start workspace by ID API method #1907
Conversation
|
@evoevodin @skabashnyuk Please take a look |
| @@ -116,10 +116,14 @@ | |||
| * workspace ID | |||
| * @param envName | |||
| * the name of the workspace environment that should be used for start | |||
| * @param isRecover | |||
There was a problem hiding this comment.
What about option when server decides recover or not depending on auto-restore behavior?
There was a problem hiding this comment.
This is a client method and it will always send request with defined restore parameter, so server will never use auto-restore behavior if this method called
|
Please add yourself as author to the classes you changed |
|
Build # 1284 - FAILED Please check console output at http://ci.codenvy-dev.com/jenkins/job/che-pullrequests-build/1284/ to view the results. |
vinokurig
force-pushed
the
CHE-1849
branch
2 times, most recently
from
1272910 to
f304e10
Compare
|
Added myself to authors |
| } | ||
| }); | ||
| } | ||
|
|
||
| private void startById(@NotNull String workspaceId, | ||
| @Nullable String envName, | ||
| @Nullable boolean restore, |
There was a problem hiding this comment.
I mean that Nullable annotations looks useless.
There was a problem hiding this comment.
is this have to be fixed?
|
LGTM |
|
+1 |
|
Build # 1291 - FAILED Please check console output at http://ci.codenvy-dev.com/jenkins/job/che-pullrequests-build/1291/ to view the results. |
|
Build # 1294 - FAILED Please check console output at http://ci.codenvy-dev.com/jenkins/job/che-pullrequests-build/1294/ to view the results. |
|
ок |
vinokurig
force-pushed
the
CHE-1849
branch
3 times, most recently
from
b655b54 to
462c071
Compare
When user starts workspace that has snapshot the 'recover from snapshots?' dialog will be shown. If user will select not to recover and auto-restore will be enabled workspace will be recovered from snapshot anywhere.
|
Build # 1302 - FAILED Please check console output at http://ci.codenvy-dev.com/jenkins/job/che-pullrequests-build/1302/ to view the results. |
What does this PR do?
Adds query parameter to
startById()method inWorkspaceServiceto know if workspace needs to be recovered from snapshot or just to start.
Removes
recoverWorkspace()API method fromWorkspaceService.What issues does this PR fix or reference?
When user starts workspace that has snapshot the 'recover from snapshots?' dialog will be shown.
If user will select not to recover and auto-restore will be enabled workspace will be recovered from snapshot anywhere.
#1849
Tests written?
Yes
Docs requirements?
API changes