che-launcher infer Che version and self destruct itself #1881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mario Loriedo <mloriedo@redhat.com>
|
Can one of the admins verify this patch? |
TylerJewell
added
the
kind/enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The launcher container automatically retrieve its version and destruct itself at the end of execution
What issues does this PR fix or reference?
Avoid to specify the version of the che-server image with the variable CHE_VERSION
Previous Behavior
To run the nightly build of che:
docker run --rm -v /var/run/docker.sock:/var/run/docker.sock -e "CHE_VERSION=nightly" codenvy/che-launcher:nightly startNew Behavior
To run the nightly build of che:
docker run -v /var/run/docker.sock:/var/run/docker.sock codenvy/che-launcher:nightly startTests written?
No
Docs requirements?
No
Signed-off-by: Mario Loriedo mloriedo@redhat.com