Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHE-1492: automatically open the IDE after creating a project #1863

Merged
merged 1 commit into from
Jul 27, 2016

Conversation

akurinnoy
Copy link
Contributor

@akurinnoy akurinnoy commented Jul 19, 2016

What does this PR do?

It provides automatic redirection to the IDE after creating a project.
Code cleanup.

What issues does this PR fix or reference?

#1753
https://jira.codenvycorp.com/browse/CHE-1492

@codenvy-ci
Copy link

@akurinnoy akurinnoy changed the title CHE-1492: automatically open the IDE after creating a project [WIP] CHE-1492: automatically open the IDE after creating a project Jul 19, 2016
@slemeur slemeur added this to the 4.6.0 milestone Jul 19, 2016
@codenvy-ci
Copy link

@akurinnoy akurinnoy changed the title [WIP] CHE-1492: automatically open the IDE after creating a project CHE-1492: automatically open the IDE after creating a project Jul 25, 2016
@@ -554,10 +557,6 @@ export class CreateProjectCtrl {
fetchTypePromise.then(() => {
let projectTypesByCategory = projectTypeService.getProjectTypesIDs();
// now try the estimate for each source
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should remove comment if remove code below

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@olexii4
Copy link
Contributor

olexii4 commented Jul 25, 2016

LGTM

@codenvy-ci
Copy link

@akurinnoy akurinnoy added the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Jul 25, 2016
@benoitf benoitf assigned benoitf and akurinnoy and unassigned benoitf Jul 26, 2016
@bmicklea bmicklea mentioned this pull request Jul 26, 2016
64 tasks
Signed-off-by: Oleksii Kurinnyi <okurinnyi@codenvy.com>
@akurinnoy akurinnoy merged commit fec4cb7 into master Jul 27, 2016
@akurinnoy akurinnoy deleted the CHE-1492 branch July 27, 2016 07:49
@benoitf benoitf removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Nov 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants