Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forces to use sources compatible with java8 and runtime java 11 #17194

Merged
merged 2 commits into from
Jun 22, 2020

Conversation

skabashnyuk
Copy link
Contributor

What does this PR do?

Forces to use sources compatible with java8 and runtime java 11.

In case of java 8 runtime

[INFO]
[INFO] --- maven-enforcer-plugin:3.0.0-M2:enforce (enforce-java-version) @ che-parent ---
[WARNING] Rule 0: org.apache.maven.plugins.enforcer.RequireJavaVersion failed with message:
To build this project JDK 11 (or upper) is required. Please install it.
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for Che Parent 7.15.0-SNAPSHOT:

In case java 11 code


INFO] Changes detected - recompiling the module!
[INFO] Compiling 36 source files to /Users/skabashn/dev/src/redhat/che/core/commons/che-core-commons-lang/target/classes
[INFO] -------------------------------------------------------------
[ERROR] COMPILATION ERROR :
[INFO] -------------------------------------------------------------
[ERROR] /Users/skabashn/dev/src/redhat/che/core/commons/che-core-commons-lang/src/main/java/org/eclipse/che/commons/lang/IoUtil.java:[73,34] cannot find symbol
  symbol:   method isBlank()
  location: variable name of type java.lang.String
[ERROR] /Users/skabashn/dev/src/redhat/che/core/commons/che-core-commons-lang/src/main/java/org/eclipse/che/commons/lang/IoUtil.java:[74,26] cannot find symbol
  symbol:   method repeat(int)
  location: class java.lang.String
[ERROR] /Users/skabashn/dev/src/redhat/che/core/commons/che-core-commons-lang/src/main/java/org/eclipse/che/commons/lang/IoUtil.java:[89,27] cannot find symbol
  symbol:   method isBlank()
  location: class java.lang.String
[ERROR] /Users/skabashn/dev/src/redhat/che/core/commons/che-core-commons-lang/src/main/java/org/eclipse/che/commons/lang/IoUtil.java:[89,46] cannot find symbol
  symbol:   method repeat(int)
  location: class java.lang.String
[INFO] 4 errors
[INFO] -------------------------------------------------------------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for Che Parent 7.15.0-SNAPSHOT:
[INFO]
[INFO] Che Parent ......................................... SUCCESS [  2.719 s]
[INFO] Che Core Parent .................................... SUCCESS [  0.091 s]
[INFO] Che Core :: Commons :: Parent ...................... SUCCESS [  0.078 s]
[INFO] Che Core :: Commons :: Annotations ................. SUCCESS [  3.074 s]
[INFO] Che Core :: Commons :: Java API extension classes .. FAILURE [  1.557 s]
[INFO] Che Core :: Commons :: Utilities for tests ......... SKIPPED

What issues does this PR fix or reference?

Since we might need to backport some feature for old branches it would be nice to keep source code in master java 8 compatible for some time

Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>
@che-bot che-bot added the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Jun 19, 2020
@metlos metlos self-requested a review June 19, 2020 08:12
@che-bot
Copy link
Contributor

che-bot commented Jun 19, 2020

✅ E2E Happy path tests succeed 🎉

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

Copy link
Contributor

@nickboldt nickboldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me.

@skabashnyuk
Copy link
Contributor Author

[ci-build]

Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>
@che-bot
Copy link
Contributor

che-bot commented Jun 22, 2020

❌ E2E Happy path tests failed ❗

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

ℹ️ Use comment "[crw-ci-test]" to rerun happy path E2E test.

@skabashnyuk
Copy link
Contributor Author

[crw-test]

@skabashnyuk
Copy link
Contributor Author

[crw-ci-test]

@skabashnyuk
Copy link
Contributor Author

ci-build

@che-bot
Copy link
Contributor

che-bot commented Jun 22, 2020

✅ E2E Happy path tests succeed 🎉

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

@skabashnyuk
Copy link
Contributor Author

ci-build

@skabashnyuk
Copy link
Contributor Author

[ci-build]

@skabashnyuk skabashnyuk merged commit b9129dd into eclipse-che:master Jun 22, 2020
@skabashnyuk skabashnyuk deleted the java8sources branch June 22, 2020 17:50
@che-bot che-bot removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants