CHE-920: Fix activation breakpoints inside nested java classes #1609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrienkoAleksandr
force-pushed
the
CHE-920
branch
from
e556769 to
cbe80c3
Compare
| @@ -444,6 +443,7 @@ protected void startDebugger(final DebugSessionDto debugSessionDto) { | |||
| LocationDto locationDto = dtoFactory.createDto(LocationDto.class); | |||
| locationDto.setLineNumber(b.getLineNumber() + 1); | |||
| locationDto.setResourcePath(b.getPath()); | |||
| locationDto.setResourceProjectPath(b.getFile().getProject().getProjectConfig().getPath()); | |||
There was a problem hiding this comment.
mb it would be better
dtoFactory.createDto(LocationDto.class);
.withLineNumber(b.getLineNumber() + 1);
.withResourcePath(b.getPath());
.withResourceProjectPath(b.getFile().getProject().getProjectConfig().getPath());
There was a problem hiding this comment.
What is b? Rename it at least to breakpoint.
AndrienkoAleksandr
force-pushed
the
CHE-920
branch
from
cbe80c3 to
d2ff50f
Compare
|
ok |
AndrienkoAleksandr
force-pushed
the
CHE-920
branch
from
d2ff50f to
f19d971
Compare
|
Build # 1114 - FAILED Please check console output at http://ci.codenvy-dev.com/jenkins/job/che-pullrequests-build/1114/ to view the results. |
|
ok |
AndrienkoAleksandr
force-pushed
the
CHE-920
branch
from
f19d971 to
95dc4a7
Compare
AndrienkoAleksandr
force-pushed
the
CHE-920
branch
from
95dc4a7 to
b81457b
Compare
|
ok |
|
Build # 1146 - FAILED Please check console output at http://ci.codenvy-dev.com/jenkins/job/che-pullrequests-build/1146/ to view the results. |
Add possibility to find fqn for nested classes inside outer classes with help JDT and use found fqns to activate breakpoints inside nested classes for the java debugger. Signed-off-by: Aleksandr Andrienko <aandrienko@codenvy.com>
AndrienkoAleksandr
force-pushed
the
CHE-920
branch
from
b81457b to
2045b9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add possibility to find fqn for nested classes inside outer classes with help JDT and use found fqns to activate breakpoints inside nested classes for the java debugger.
@vparfonov @vzhukovskii @sleshchenko @azatsarynnyy @evidolob @tolusha review please.