CHE-1277 Move machines output to project perpective #1574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vitaliy Guliy <vguliy@codenvy.com>
|
|
||
| public static final GwtEvent.Type<WorkspaceStartingEvent.Handler> TYPE = new GwtEvent.Type<>(); | ||
|
|
||
| private final WorkspaceDto workspace; |
There was a problem hiding this comment.
What was the motivation for using DTO object here instead of an appropriate model object Workspace?
There was a problem hiding this comment.
No special motivation, just the same as in WorkspaceStartedEvent and WorkspaceStoppedEvent
There was a problem hiding this comment.
We should use DTO for transport only.
And model interfaces in other places like this event class.
Signed-off-by: Vitaliy Guliy <vguliy@codenvy.com>
|
+1 |
|
ok |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_1 Upvote_ Signed-off-by: Vitaliy Guliy vguliy@codenvy.com