Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codenvy 694 remove unused field of WorkspaceManager and add getByNamespace manager mehod #1555

Merged
merged 5 commits into from
Jun 23, 2016

Conversation

mshaposhnik
Copy link
Contributor

No description provided.

@codenvy-ci
Copy link

@garagatyi
Copy link

LGTM

* when any server error occurs while getting workspaces with {@link WorkspaceDao#getByNamespace(String)}
*/
public List<WorkspaceImpl> getByNamespace(String namespace) throws ServerException {
requireNonNull(namespace, "Required non-null user namespace");
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Word "user" not need here

@mshaposhnik mshaposhnik changed the title Codenvy 694 remove unused field of WorkspaceManager Codenvy 694 remove unused field of WorkspaceManager and add getByNamespace manager mehod Jun 23, 2016
@skabashnyuk
Copy link
Contributor

ок, @sleshchenko ?

@sleshchenko
Copy link
Member

Ok for me

@mshaposhnik mshaposhnik merged commit 25e6cc2 into master Jun 23, 2016
@mshaposhnik mshaposhnik deleted the CODENVY-694 branch June 23, 2016 12:38
@codenvy-ci
Copy link

riuvshin pushed a commit that referenced this pull request Jun 24, 2016
…space manager mehod (#1555)

* CODENVY-694; remove unused field and add getByNamespace manager mehod
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants