-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CHE-1095: add new UD/IDE navigation experience #1508
Conversation
} | ||
|
||
/** | ||
* Sends a message to the parent frame to inform that IDE ide has been loaded. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"IDE ide" -> "IDE application"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
License check fails - to fix execute: |
</g> | ||
</g> | ||
</g> | ||
</svg> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing EOL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
this.iframeAdded = false; | ||
this.$timeout = $timeout; | ||
this.$compile = $compile; | ||
|
||
$window.addEventListener("message", function(event) { | ||
if ("ide-loaded" == event.data) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dealt to use strict equals
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
Build # 916 - FAILED Please check console output at http://ci.codenvy-dev.com/jenkins/job/che-pullrequests-build/916/ to view the results. |
PR needs to be rebased (conflicts) |
$navbar-menu-text-color = $mouse-gray-color | ||
$navbar-menu-dark-text-color = $navbar-menu-icon-color | ||
$navbar-active-menu-text-color = $light-gray-color | ||
$navbar-section-title-color = #62687C |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why these constants hardcoded there (not in che-colors.json)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added black color into che-colors.json .
Other colors are belong to specific theme of navbar and it doesn't make sense to put them to general colors list. So I move them into separate .styl file.
Build # 927 - FAILED Please check console output at http://ci.codenvy-dev.com/jenkins/job/che-pullrequests-build/927/ to view the results. |
Goals: - revamp the left navbar - remove the mobile responsiveness - add ability to jump into recent workspace - improve the branding/consistency between UD/IDE Signed-off-by: Oleksii Kurinnyi <okurinnyi@codenvy.com>
Build # 936 - FAILED Please check console output at http://ci.codenvy-dev.com/jenkins/job/che-pullrequests-build/936/ to view the results. |
Goals:
Signed-off-by: Oleksii Kurinnyi okurinnyi@codenvy.com