Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHE-1337: fix import Maven project form dashboard #1506

Merged
merged 1 commit into from
Jun 14, 2016
Merged

Conversation

olexii4
Copy link
Contributor

@olexii4 olexii4 commented Jun 14, 2016

_1 Upvote_ Signed-off-by: Oleksii Orel oorel@codenvy.com

Signed-off-by: Oleksii Orel <oorel@codenvy.com>
@slemeur
Copy link
Contributor

slemeur commented Jun 14, 2016

+1 - for the time being and resolution of import maven project

let projectType = projectTypesByCategory.get(type);
if (projectType && projectType.parents) {
projectType.parents.forEach((parentType) => {
if (parentType === 'java') {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we avoid hard-coding here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we have the same in IDE as java is not shown

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I try to get project types: /wsagent/ext/project-type (GET)
Response:
0: {persisted: false, parents: ["java"], mixable: false, primaryable: true,…id: "javac"...}
1: {persisted: false, parents: ["blank"], mixable: false, primaryable: true,…id: "cpp"...}
2: {persisted: false, parents: ["blank"], mixable: false, primaryable: true, ... id: "python",…}
3: {persisted: false, parents: [], mixable: false, primaryable: true, ancestors: [], id: "blank",…}
4: {persisted: false, parents: ["blank"], mixable: false, primaryable: true, ... id: "java",…}
5: {persisted: false, parents: ["blank"], mixable: true, primaryable: false, ... id: "git",…}
6: {persisted: false, parents: ["blank"], mixable: false, primaryable: true, ... id: "node-js",…}
7: {persisted: false, parents: ["blank"], mixable: false, primaryable: true, ... id: "c",…}
8: {persisted: false, parents: ["blank"], mixable: true, primaryable: false, ... id: "subversion",…}
9: {persisted: false, parents: ["java"], mixable: false, primaryable: true, ... id: "maven", ...}

@vparfonov: What should we do for 4.4 version with this parent type in case when we have more than one valid type with attributes( like 'maven' and 'jjavac')?

@vparfonov
Copy link
Contributor

@benoitf

@benoitf
Copy link
Contributor

benoitf commented Jun 14, 2016

OK only for 4.3.2 this has to be written correctly and work smoothly from server

@riuvshin
Copy link
Contributor

OK, thanks!

@riuvshin riuvshin merged commit 1ea6b89 into master Jun 14, 2016
@codenvy-ci
Copy link

@olexii4 olexii4 deleted the CHE-1337 branch July 19, 2016 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants