-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docker group IDs for boot2docker and Docker for Mac Beta #1490
Conversation
Can one of the admins verify this patch? |
lgtm @l0rd - can you confirm you have a CLA on file with Eclipse foundation? I have to assume you do. But the GitHub / Eclipse integration regularly seems to report users as not having a valid CLA. We can ignore it if you do. |
I'll do that as soon as eclipse servers get back online. I can't log in right now. |
@eivantsov @riuvshin - please review. |
Looks like #1576 has part of changes from this PR. Why do you need both? |
That's a rebase issue. I've rebased that commit on top #1576 to generate On Friday, 24 June 2016, Alexander Garagatyi notifications@github.com
|
Signed-off-by: Mario Loriedo <mloriedo@redhat.com>
@garagatyi should be ok now |
LGTM |
This is related to #1482. When running Che server inside a container, adding user to the local docker group (gid=999) is not enough. User should be added to the Docker host group too.
And in Docker for Mac Beta VM docker gid is 50, in boot2docker 100.
It worked accidentally on boot2docker because container
user
group and Docker hostdocker
group had the same gid. But it did not work on Docker for Mac Beta.Signed-off-by: Mario Loriedo mario.loriedo@gmail.com