CODENVY-27; allow to open workspaces by using /ide/namespace/ws_name schema #1463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| package org.eclipse.che; | ||
|
|
||
|
|
||
| import javax.servlet.*; |
There was a problem hiding this comment.
We should not use * in imports
| @@ -120,7 +121,7 @@ public void setUp() throws Exception { | |||
| EnvironmentContext.setCurrent(new EnvironmentContext() { | |||
| @Override | |||
| public Subject getSubject() { | |||
| return new SubjectImpl("Test User", USER_ID, "token", new ArrayList<>(), false); | |||
| return new SubjectImpl(NAMESPACE, USER_ID, "token", new ArrayList<>(), false); | |||
There was a problem hiding this comment.
do we need arraylist or an empty list ?
There was a problem hiding this comment.
Do you imply Collections.emptyList() here ?
There was a problem hiding this comment.
We can simply pass null and new emptySet ill be created
|
Other ok |
|
ok |
| @@ -247,7 +245,7 @@ public void delete(@ApiParam("The workspace id") @PathParam("id") String id) thr | |||
| ConflictException, | |||
| ForbiddenException { | |||
| if (!workspaceManager.getSnapshot(id).isEmpty()) { | |||
| machineManager.removeSnapshots(getCurrentUserId(), id); | |||
| machineManager.removeSnapshots(EnvironmentContext.getCurrent().getSubject().getUserId(), id); | |||
There was a problem hiding this comment.
https://github.com/eclipse/che/blob/master/wsmaster/che-core-api-machine/src/main/java/org/eclipse/che/api/machine/server/dao/SnapshotDao.java#L78-78
namespace should be equal to user name, no?
skabashnyuk
pushed a commit
that referenced
this pull request
Jan 3, 2020
…schema (#1463) * CODENVY-27; use /namespace/ws_name URL schema for IDE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.