Fix docker image reference parsing by DockerImageIdentifierParser #1420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@skabashnyuk @evoevodin @benoitf Please review |
|
ок |
| throw new DockerFileException("Provided image reference is invalid"); | ||
| index = workingCopyOfImage.indexOf('/'); | ||
| String beforeSlash = index > -1 ? workingCopyOfImage.substring(0, index) : ""; | ||
| if (beforeSlash.isEmpty() || (!beforeSlash.contains(".") && |
There was a problem hiding this comment.
It is not clear from the context what these contains(...) invocations actually check, consider extracting this condition into the method or adding a comment explaining the context of the condition.
|
The solution is okay for me, please fix the comments above. |
|
OK |
|
Build # 799 - FAILED Please check console output at http://ci.codenvy-dev.com/jenkins/job/che-pullrequests-build/799/ to view the results. |
garagatyi
force-pushed
the
fixDockerImageParser
branch
from
1b79b01 to
02d3491
Compare
Parsing used to use reference definition from docker repo, but fails in some very simple cases. Rework parsing. Add comments. Add tests. Signed-off-by: Alexander Garagatyi <agaragatyi@codenvy.com>
garagatyi
force-pushed
the
fixDockerImageParser
branch
from
02d3491 to
fd9576b
Compare
|
Build # 807 - FAILED Please check console output at http://ci.codenvy-dev.com/jenkins/job/che-pullrequests-build/807/ to view the results. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parsing used to use reference definition from docker repo, but
fails in some very simple cases.
Rework parsing. Add comments. Add tests.