CHE-1196: Artik: Debugger hangs when debugging binaries using Artik SDK #1418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tolusha
commented
Jun 3, 2016
tolusha
commented
- Fix synchronization issue
- Respect gdb termination
- Fix UI bugs
|
@vparfonov |
| return GdbInfoLocals.parse(outputs.take()); | ||
| public GdbInfoLocals infoLocals() throws IOException, InterruptedException, DebuggerException { | ||
| GdbOutput gdbOutput = sendCommand("info locals"); | ||
| return GdbInfoLocals.parse(gdbOutput); |
There was a problem hiding this comment.
WDYT about inlining these methods as
return GdbInfoLocals.parse(sendCommand("info locals"));
?
There was a problem hiding this comment.
I personally prefer splitting.
In case of debugging it will help.
|
LGTM |
|
Build # 796 - FAILED Please check console output at http://ci.codenvy-dev.com/jenkins/job/che-pullrequests-build/796/ to view the results. |
|
ok |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.