Fix WorkspaceService to be able to share workspaces #1359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sleshchenko
force-pushed
the
workspacePermissions
branch
4 times, most recently
from
6595163 to
38a31df
Compare
| @@ -133,13 +133,13 @@ | |||
| List<WorkspaceImpl> getByNamespace(String namespace) throws ServerException; | |||
|
|
|||
| /** | |||
| * Gets list of workspaces where user is worker | |||
| * Gets list of workspaces where given user is worker and has read permission | |||
There was a problem hiding this comment.
WorkspaceDao should check permissions?
There was a problem hiding this comment.
It should get all workspaces by relation between user and workspace. Take a look implementation in codenvy project https://github.com/codenvy/codenvy/blob/workspacePermissions/core/codenvy-hosted-platform-api-impl/src/main/java/com/codenvy/api/dao/mongo/WorkspaceDaoImpl.java#L264-264
sleshchenko
force-pushed
the
workspacePermissions
branch
from
38a31df to
84c7c3e
Compare
sleshchenko
force-pushed
the
workspacePermissions
branch
2 times, most recently
from
76bd716 to
628e52b
Compare
sleshchenko
force-pushed
the
workspacePermissions
branch
from
628e52b to
b485b2e
Compare
sleshchenko
changed the title
| requireNonNull(namespace, "Required non-null workspace namespace"); | ||
| final List<WorkspaceImpl> workspaces = workspaceDao.getByNamespace(namespace); | ||
| public List<WorkspaceImpl> getWorkspaces(String user) throws ServerException { | ||
| requireNonNull(user, "Required non-null workspace namespace"); |
|
The |
|
ok |
sleshchenko
force-pushed
the
workspacePermissions
branch
from
8148a3a to
7563a11
Compare
|
Build # 736 - FAILED Please check console output at http://ci.codenvy-dev.com/jenkins/job/che-pullrequests-build/736/ to view the results. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@skabashnyuk Can you please review my changes?
@evoevodin Can you please take a look changes in WorkspaceManager?