CHE-1204. Use correct url for request on FormatService #1347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -116,8 +116,7 @@ public String getProposalDocUrl(int id, String sessionId) { | |||
| return newPromise(new AsyncPromiseHelper.RequestCall<List<Change>>() { | |||
| @Override | |||
| public void makeCall(AsyncCallback<List<Change>> callback) { | |||
| String url = appContext.getDevMachine().getWsAgentBaseUrl() + "/code-formatting/format?offset=" + offset + | |||
| "&length=" + length; | |||
| String url = appContext.getDevMachine().getWsAgentBaseUrl() + "/java/code-formatting/format?offset=" + offset + "&length=" + length; | |||
There was a problem hiding this comment.
should we use a constant prefix for all the paths of this class ?
constant being "/java/code-formatting/" to avoid to miss some endpoint in a future
|
Build # 698 - FAILED Please check console output at http://ci.codenvy-dev.com/jenkins/job/che-pullrequests-build/698/ to view the results. |
|
ci-build |
|
ok |
| @ApiParam(value = "The given length to stop recording the edits (exclusive)") | ||
| @QueryParam("length") int length, | ||
| @ApiParam(value = "The content to format") | ||
| final String content) throws BadLocationException, IllegalArgumentException { |
There was a problem hiding this comment.
Do we have description of content format?
There was a problem hiding this comment.
@skabashnyuk I've added note for 'content' param. WDYT?
|
ок |
Signed-off-by: Roman Nikitenko <rnikitenko@codenvy.com>
|
Build # 708 - FAILED Please check console output at http://ci.codenvy-dev.com/jenkins/job/che-pullrequests-build/708/ to view the results. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@vparfonov please review
Signed-off-by: Roman Nikitenko rnikitenko@codenvy.com