CODENVY-457: fix NPE when swarm doesn't detect container death #1344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexander Garagatyi <agaragatyi@codenvy.com>
| throw e; | ||
| } | ||
| Map<String, List<PortBinding>> ports = info.getNetworkSettings().getPorts(); | ||
| Map<String, String> labels = info.getConfig().getLabels(); |
There was a problem hiding this comment.
are you sure getNetworkSettings and getConfig are not null?
There was a problem hiding this comment.
Looks like they are never null whereas ports field is null when container is not running
|
ok |
|
@skabashnyuk Please take a look |
| // Hack needed to investigate why swarm returns invalid response | ||
| LOG.error(info.toString()); | ||
| throw e; | ||
| Map<String, List<PortBinding>> ports = Collections.emptyMap(); |
There was a problem hiding this comment.
is that Collections.emptyMap shouldn't be created in the else block ?
|
ok |
|
will it be backported to 4.3.x as well ? replacing/updating #1312 |
|
yes/yes |
|
nice to see this NPE gone |
|
Build # 696 - FAILED Please check console output at http://ci.codenvy-dev.com/jenkins/job/che-pullrequests-build/696/ to view the results. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@skabashnyuk Please review