CODENVY-538:Fix checking of recipe location: now will match only host… #1301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… wihout scheme. Add method for download file in case server send redirect(in some reason setInstanceFollowRedirects(true) don't work so need to do one more request) Signed-off-by: Vitaly Parfonov <vparfonov@codenvy.com>
| // add user token to be able to download user's private recipe | ||
| if (machineConfig.getSource().getLocation().startsWith(apiEndpoint)) { | ||
| final String apiEndPointHost = apiEndpoint.getHost(); | ||
| final String host = UriBuilder.fromUri(location).build().getHost(); |
There was a problem hiding this comment.
Why not use targetUriBuilder instead of creating new uribuilder
There was a problem hiding this comment.
@garagatyi check my fix pls
|
Build # 637 - FAILED Please check console output at http://ci.codenvy-dev.com/jenkins/job/che-pullrequests-build/637/ to view the results. |
|
ОК |
Signed-off-by: Vitaly Parfonov <vparfonov@codenvy.com>
|
LGTM |
|
Build # 645 - FAILED Please check console output at http://ci.codenvy-dev.com/jenkins/job/che-pullrequests-build/645/ to view the results. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… wihout scheme.
Add method for download file in case server send redirect(in some reason setInstanceFollowRedirects(true) don't work so need to do one more request)
Signed-off-by: Vitaly Parfonov vparfonov@codenvy.com
@skabashnyuk @garagatyi @riuvshin