CHE-137. Improve full text searching #1215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
need some test for server side |
|
-1 |
|
Build finished. |
1 similar comment
|
Build finished. |
| float: left; | ||
| line-height: 22px; | ||
| margin: 0 0 0 4px; |
There was a problem hiding this comment.
thank you, Vlad. I'll fix.
|
@skabashnyuk @vparfonov I've updated pull request, please review. |
RomanNikitenko
changed the title
| @@ -242,15 +242,15 @@ private Query createLuceneQuery(QueryExpression query) throws ServerException { | |||
| final String path = query.getPath(); | |||
| final String text = query.getText(); | |||
| if (path != null) { | |||
| luceneQuery.add(new PrefixQuery(new Term("path", path)), BooleanClause.Occur.MUST); | |||
| luceneQuery.add(new PrefixQuery(new Term("path", path)), MUST); | |||
There was a problem hiding this comment.
I think we should keep BooleanClause.Occur.MUST way. It has much more descriptive.
There was a problem hiding this comment.
@skabashnyuk done!
|
other ok |
|
OK for me |
|
ok |
Signed-off-by: Roman Nikitenko <rnikitenko@codenvy.com>
|
Build # 573 - FAILED Please check console output at http://ci.codenvy-dev.com/jenkins/job/che-pullrequests-build/573/ to view the results. |
Katka92
pushed a commit
to Katka92/che
that referenced
this pull request
Jun 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before my changes
after my changes
@skabashnyuk @vparfonov @slemeur