New command for compiling and running simple java project #1213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -54,8 +56,8 @@ public String getKey() { | |||
| } | |||
|
|
|||
| @Override | |||
| public String getValue() { | |||
| return value; | |||
| public Promise<String> getValue() { | |||
There was a problem hiding this comment.
Can you explain why did you do these changes?
There was a problem hiding this comment.
The process of the configuring command line should be asynchronous, because some providers send request to the server for getting value (f.e. getting classpath).
|
is that ${project.classpath} shouldn't include "java" ? because for other projects it may be strange |
| * | ||
| * @author Valeriy Svydenko | ||
| */ | ||
| public class ClasspathChangeEvent extends GwtEvent<ClasspathChangeEvent.ClasspathChangeHandler> { |
|
@benoitf Make sense, I think ${project.java.classpath} will be ok. |
| } | ||
|
|
||
| String languageAttribute = currentProject.getAttributeValue(Constants.LANGUAGE); | ||
| if (Strings.isNullOrEmpty(languageAttribute) || !Constants.JAVA_ID.equals(languageAttribute)) { |
There was a problem hiding this comment.
the same to #1213 (comment)
|
Build finished. |
2 similar comments
|
Build finished. |
|
Build finished. |
|
ok |
Signed-off-by: Valeriy Svydenko <vsvydenko@codenvy.com>
|
Build finished. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Command view:
@vparfonov @azatsarynnyy