Add VM mount to backup workspaces and prefs on host file system #1176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTMN |
|
Three basic changes proposed.
|
|
+1 on this |
Signed-off-by: Eugene Ivantsov <eivantsov@codenvy.com>
ghost
force-pushed
the
vagrant_mount_and_config
branch
from
bc46c75 to
831a5d4
Compare
|
@TylerJewell @riuvshin I have updated the PR. che.properties is copied and updated now in ~/.che which is set to be the location of CHE_LOCAL_CONF_DIR |
|
Build finished. |
|
@eivantsov LGTM. Question - did you not need to source .bashrc after you modify the file? I am surprised that the modification to the environment variable was picked up. |
|
It's picked up since I both export it in the command line and in .bashrc. So, it works for Vagrant because of export in the command line, and for user (when logged in) in .bashrc. |
|
Great - will you consider doing a similar PR for the ARTIK IDE Vagrantfile? |
|
yes, sure |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_1 Upvote_ @TylerJewell @riuvshin please take a look. This way we auto mount a current dir into
~/che-storagewhich is configured as storage for Che workspaces and prefs inside a VM. As a result, even when a box is destroyed, workspaces, projects and prefs are there.Signed-off-by: Eugene Ivantsov eivantsov@codenvy.com