Use HttpJsonRequest instead of HttpJsonHelper #1163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ok |
|
Can we remove HttpJsonHelper after that? |
|
Yes, we can! |
| @@ -95,8 +97,11 @@ public ServiceDescriptor getServiceDescriptor() throws IOException, ServerExcept | |||
| myServiceDescriptor = serviceDescriptor; | |||
| if (myServiceDescriptor == null) { | |||
| try { | |||
| myServiceDescriptor = serviceDescriptor = HttpJsonHelper.options(getServiceDescriptorClass(), baseUrl); | |||
| } catch (NotFoundException | ConflictException | UnauthorizedException | ForbiddenException e) { | |||
| myServiceDescriptor = serviceDescriptor = requestFactory.fromUrl(baseUrl) | |||
There was a problem hiding this comment.
WDYT about rewriting this method without myServiceDescriptor variable?
if (serviceDescriptor == null) {
synchronized (this) {
if (serviceDescriptor == null) {
try {
return serviceDescriptor = requestFactory.fromUrl(baseUrl)
.useOptionsMethod()
.request()
.as(getServiceDescriptorClass(), null);
} catch (NotFoundException | ConflictException | UnauthorizedException | ForbiddenException e) {
throw new ServerException(e.getServiceError());
}
}
}
}
There was a problem hiding this comment.
Looks OK for me from concurrency POW. @evoevodin WDYT?
|
LGTM |
|
ok |
Signed-off-by: Alexander Garagatyi <agaragatyi@codenvy.com>
garagatyi
force-pushed
the
shineDownHttpJsonHelper
branch
from
cc3e3ce to
0985c2f
Compare
Signed-off-by: Alexander Garagatyi <agaragatyi@codenvy.com>
|
Hi, |
|
@tareqhs Yes. If you want you can do so. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@skabashnyuk @sleshchenko @evoevodin Please review