CHE-976: Generify debugge API #1159
Conversation
| import java.util.Map; | ||
|
|
||
| /** | ||
| * The client-side service to debug application. |
There was a problem hiding this comment.
I'd say it's rather Client for the service to debug application.
As for me, unusuall definition - client-side service
|
@evoevodin |
| @@ -68,10 +67,9 @@ protected void configure() { | |||
| install(new ArchetypeGeneratorModule()); | |||
| install(new GitHubModule()); | |||
| install(new org.eclipse.che.swagger.deploy.DocsModule()); | |||
| install(new DebuggerModule()); | |||
There was a problem hiding this comment.
I think here should be full fqn: install(new org.eclipse.che.api.debugger.server.DebuggerModule());
|
DTO objects are for transport only, for sending/receiving stuffs via REST |
AndrienkoAleksandr
force-pushed
the
CHE-976
branch
from
333ff2b to
83964e7
Compare
|
Build finished. |
| Map<String, String> locals = gdb.infoLocals().getVariables(); | ||
| locals.putAll(gdb.infoArgs().getVariables()); | ||
|
|
||
| List<Variable> variables = new ArrayList<>(); |
There was a problem hiding this comment.
It seems that you already know the size of the ArrayList at this point
|
Build finished. |
| @Override | ||
| public Debugger create(Map<String, String> properties, Debugger.DebuggerCallBack debuggerCallBack) throws DebuggerException { | ||
| Map<String, String> normalizedProps = new HashMap<>(properties.size()); | ||
| properties.keySet().stream().forEach(key -> normalizedProps.put(key.toLowerCase(), properties.get(key))); |
There was a problem hiding this comment.
I prefer to use collect in such cases
normalizedProps = properties.entrySet()
.stream()
.collect(toMap(e -> e.getKey().toLowerCase(), Map.Entry::getValue); 
|
Well, i reviewed 20% of the pull request and it is impossible to review the rest, because pull request is too large. @tolusha can you please separate you pull request on different commits, e.g. (model, spi, api, refactoring) because it is impossible to review some classes such as |
| @@ -57,6 +57,14 @@ | |||
| </dependency> | |||
| <dependency> | |||
| <groupId>org.eclipse.che.core</groupId> | |||
| <artifactId>che-core-api-debugger-shared</artifactId> | |||
|
Build finished. |
1 similar comment
|
Build finished. |
|
Build finished. |
|
Build finished. |
|
Don't review all changes because a lot of files, but basically looks good for me ok |
|
Build # 555 - $BUILD_STATUS: Please check console output at http://ci.codenvy-dev.com/jenkins/job/che-pullrequests-build/555/ to view the results. Failed tests: ${FAILED_TESTS} |
No description provided.