Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHE-1004: Improve experience on Debugger configuration selection #1094

Merged
merged 1 commit into from
Apr 20, 2016

Conversation

azatsarynnyy
Copy link
Member

@azatsarynnyy azatsarynnyy commented Apr 20, 2016

  • added facade for debug configuration related operations (DebugConfigurationsManager) in Debugger API;
  • drop-down list for selecting debug configuration removed from toolbar;
  • all debug configurations are available for selecting as actions in Run -> Debug Configurations menu.

@vparfonov

if (data.isPresent() && !data.get().isEmpty()) {
configurationsList = dtoFactory.createListDtoFromJson(data.get(), DebugConfigurationDto.class);
} else {
configurationsList = new ArrayList<>(0);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

emptyList()

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

* Creates new configuration with the given parameters.
*
* @return created {@link DebugConfiguration}
* @throws IllegalArgumentException
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The method isn't throwing any exception

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx, fixed

@vparfonov
Copy link
Contributor

Ok

@azatsarynnyy azatsarynnyy merged commit 198f7fa into master Apr 20, 2016
@azatsarynnyy azatsarynnyy deleted the CHE-1004 branch April 20, 2016 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants