[WIP] Remove usage of MachineExtensionProxyServlet #1052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -105,13 +105,20 @@ public void startWsAgent(String workspaceId) throws NotFoundException, MachineEx | |||
| } catch (BadRequestException wsAgentLaunchingExc) { | |||
| throw new MachineException(wsAgentLaunchingExc.getLocalizedMessage(), wsAgentLaunchingExc); | |||
| } | |||
| LOG.error(String.format("Fail pinging ws agent. Workspace ID:%s. Url:%s. Timestamp:{}",workspaceId,UriBuilder.fromUri(devMachine.getRuntime() | |||
There was a problem hiding this comment.
Please do not use String.format here. LOG.error has its own API to submit parameters - "{}"
garagatyi
changed the title
| @@ -126,8 +128,8 @@ public void makeCall(AsyncCallback<CompilationUnit> callback) { | |||
|
|
|||
| @Override | |||
| public Promise<ImplementationsDescriptorDTO> getImplementations(String projectPath, String fqn, int offset) { | |||
| final String url = restContext + "/jdt/" + workspaceId + "/navigation/implementations?projectpath=" + projectPath + "&fqn=" + fqn + | |||
| "&offset=" + offset; | |||
| final String url =appContext.getDevMachine().getWsAgentBaseUrl() + "/jdt/" + workspaceId + "/navigation/implementations" + | |||
|
other OK for me |
| --> | ||
| <Context allowCasualMultipartParsing="true"> | ||
| <Valve className="org.apache.catalina.valves.rewrite.RewriteValve"/> | ||
| </Context> |
There was a problem hiding this comment.
Please add new line at the end of file
|
Except those lines that I commented everything is OK. Great job! |
|
all comments are fixed |
|
LGTM |
Add path to wsagent into wsagent server url to avoid doing that on client-side Add class DevMachine on client-side what contain all needed information for communicate with wsagent and terminal Remove @nAmed(cheExtensionPath) Signed-off-by: Vitaly Parfonov <vparfonov@codenvy.com>
vparfonov
force-pushed
the
CHE-708_CHE-869
branch
from
94a7a0e to
91f6a64
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add path to wsagent into wsagent server url to avoid doing that on clients.
Add class DevMachine on client-side what contain all needed information for communicate with wsagent and terminal
@skabashnyuk @sleshchenko @garagatyi