CODENVY-256 Plugin Artik #1043
Merged
CODENVY-256 Plugin Artik #1043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vitaliy Guliy <vguliy@codenvy.com>
| final String machineId = machine.getId(); | ||
|
|
||
| MachineDto deletedAction = registeredMachineMap.get(machineId); | ||
| if (deletedAction == null) { |
There was a problem hiding this comment.
Getting value before removing it from map there is redundant.
You can combine it in one line:
if (registeredMachineMap.remove(machineId) == null)
There was a problem hiding this comment.
Let you create an issue for that
There was a problem hiding this comment.
Fixed. Will be pushed in my next PR.
|
ok |
| final MachineDto machine = machineEntry.getValue(); | ||
| final MachineConfigDto machineConfig = machine.getConfig(); | ||
|
|
||
| if (!this.getMachineCategory(machineConfig).equals(machineCategory)) { |
There was a problem hiding this comment.
Why you are using this link in some places if it may be omitted?
| * Provides methods which allow change visual representation of header of the list. | ||
| * | ||
| * @author Valeriy Svydenko | ||
| * @author Oleksii Orel |
There was a problem hiding this comment.
You've created a new file, but you haven't mentioned as author :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vitaliy Guliy vguliy@codenvy.com