Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CHE-10097, CHE-10098, CHE-256: fix bugs related to installers on Stack Details page #10367

Merged
merged 8 commits into from
Jul 20, 2018
Merged

CHE-10097, CHE-10098, CHE-256: fix bugs related to installers on Stack Details page #10367

merged 8 commits into from
Jul 20, 2018

Conversation

akurinnoy
Copy link
Contributor

What does this PR do?

Bugs which are fixed by this PR:

  • displaying multiple installers with the same id in the installers list;
  • canceling changes once doesn't allow to save further changes;
  • unexpected page scrolling after switching installers on or off;
  • unexpected page scrolling after canceling changes when installers list in the viewport;

What issues does this PR fix or reference?

fix #10097
fix #10098
fix #10256

Release Notes

N/A - bugfix

Docs PR

N/A - bugfix

@akurinnoy akurinnoy added the kind/bug Outline of a bug - must adhere to the bug report template. label Jul 10, 2018
@akurinnoy akurinnoy self-assigned this Jul 10, 2018
@akurinnoy akurinnoy requested review from benoitf and ashumilova July 10, 2018 15:32
@akurinnoy
Copy link
Contributor Author

ci-test

@riuvshin
Copy link
Contributor

Can one of the admins verify this patch?

@eclipse-che eclipse-che deleted a comment from SkorikSergey Jul 11, 2018
@eclipse-che eclipse-che deleted a comment from SkorikSergey Jul 11, 2018
@eclipse-che eclipse-che deleted a comment from SkorikSergey Jul 11, 2018
@eclipse-che eclipse-che deleted a comment from SkorikSergey Jul 11, 2018
@eclipse-che eclipse-che deleted a comment from SkorikSergey Jul 11, 2018
@eclipse-che eclipse-che deleted a comment from SkorikSergey Jul 11, 2018
@riuvshin
Copy link
Contributor

ci-test

@ashumilova ashumilova mentioned this pull request Jul 11, 2018
Closed
20 tasks
@riuvshin
Copy link
Contributor

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:10367
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@vkuznyetsov vkuznyetsov mentioned this pull request Jul 11, 2018
Closed
39 tasks
@benoitf benoitf added the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Jul 11, 2018
@SkorikSergey
Copy link
Contributor

ci-test

@riuvshin
Copy link
Contributor

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:10367
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@akurinnoy
Copy link
Contributor Author

ci-test

@riuvshin
Copy link
Contributor

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:10367
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@SkorikSergey
Copy link
Contributor

ci-test

@riuvshin
Copy link
Contributor

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:10367
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

akurinnoy added 5 commits July 18, 2018 17:07
@akurinnoy
add unit tests for stack-details directive
14048b0 
Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
@akurinnoy
CHE-10098: fix multiple installers
ffc4c19 
replace the obsolete installers list with the currently used one

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
@akurinnoy
fix a bug regarding saving installer states
5556d9c 
switching several installers in a row causes a bug when only the last
installer's state is stored in a stack configuration.

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
@akurinnoy
CHE-10256: fix overlay
2569919 
Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
@akurinnoy
CHE-10097: fix unexpected page scroll
f024a20 
Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>
@akurinnoy
Copy link
Contributor Author

ci-test

@riuvshin
Copy link
Contributor

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:10367
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@akurinnoy
Copy link
Contributor Author

ci-test

@riuvshin
Copy link
Contributor

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:10367
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@Ohrimenko1988
Copy link
Contributor

Selenium tests execution on Eclipse Che Multiuser on OCP
(https://ci.codenvycorp.com/job/che-pullrequests-test-ocp/497/Selenium_20tests_20report/)
doesn't show any regression against this Pull Request.

@akurinnoy akurinnoy merged commit 3bd86ee into eclipse-che:master Jul 20, 2018
@benoitf benoitf removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Jul 20, 2018
@benoitf benoitf added this to the 6.9.0 milestone Jul 20, 2018
@akurinnoy akurinnoy deleted the CHE-10097 branch August 23, 2018 10:20
skabashnyuk pushed a commit that referenced this pull request Jan 3, 2020
@akurinnoy
CHE-10097, CHE-10098, CHE-256: fix bugs related to installers on Stac…
bc66459 
…k Details page (#10367)

* CHE-10098: fix multiple installers

replace the obsolete installers list with the currently used one

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>

* fix a bug regarding saving installer states

switching several installers in a row causes a bug when only the last
installer's state is stored in a stack configuration.

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>

* CHE-10256: fix overlay

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>

* add unit tests for stack-details directive

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>

* CHE-10097: fix unexpected page scroll

Signed-off-by: Oleksii Kurinnyi <okurinny@redhat.com>

* fixup! CHE-10097: fix unexpected page scroll

* fixup! fixup! CHE-10097: fix unexpected page scroll

* fixup! fixup! fixup! CHE-10097: fix unexpected page scroll
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benoitf benoitf benoitf approved these changes

@ashumilova ashumilova ashumilova approved these changes

Assignees

@akurinnoy akurinnoy

Labels
kind/bug Outline of a bug - must adhere to the bug report template.
Projects
None yet
Milestone
6.9.0
6 participants
@akurinnoy @riuvshin @SkorikSergey @Ohrimenko1988 @benoitf @ashumilova