CHE-750 Remove snapshots on workspace removal #1015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
ok |
| @@ -279,6 +279,9 @@ public void delete(@ApiParam("The workspace id") @PathParam("id") String id) thr | |||
| ConflictException, | |||
| ForbiddenException { | |||
| ensureUserIsWorkspaceOwner(id); | |||
| if (!workspaceManager.getSnapshot(id).isEmpty()) { | |||
There was a problem hiding this comment.
I understand that it is out scope of current issue. But maybe it would be better to rename getSnapshot to getSnapshots?
There was a problem hiding this comment.
I think no, the main idea of this method name is get workspace snapshot which is actually the list of machine snapshots, we also planed to create separate object describing workspace snapshot, that's why this name fits our needs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@evoevodin @garagatyi review please