Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the Che-specific features we've added to Che's VS Code editor #21835

Closed
azatsarynnyy opened this issue Nov 23, 2022 · 12 comments
Closed
Labels
area/doc Issues related to documentation kind/epic A long-lived, PM-driven feature request. Must include a checklist of items that must be completed. kind/task Internal things, technical debt, and to-do tasks to be performed. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. severity/P1 Has a major impact to usage or development of the system.

Comments

@azatsarynnyy
Copy link
Member

azatsarynnyy commented Nov 23, 2022

Is your task related to a problem? Please describe

In the Che-Code project, we extended the vanilla VS Code with the Che-specific features and made some adaptations of VS Code's internals to the Che environment.

While it does everything the user might expect from VS Code running in Che, there's no way to read the details of using the particular feature and learn about some important aspects of its behavior.

Describe the solution you'd like

We need to document all the Che-specific features, we've added to our VS Code assembly, on the Che documentation website.

Describe alternatives you've considered

No response

Additional context

Below is the list of the features we can consider to document:

  • running the Devfile Commands as VS Code Tasks with the possibility to run them in any container
  • opening VS Code terminals to DevWorkspace containers
  • detection of the opened ports and suggestions exposing corresponding apps' URLs
  • monitoring the system resources of the DevWorkspace containers
  • authentication on GitHub
  • sending the user's activities to prevent a DevWorkspace from stopping by an idle timeout
  • added the helper extension to interact with DevWorkspace. It may be used by the custom extensions which need to work with DevWorkspace directly
  • navigating to Che Dashboard from the IDE

Some low-level adaptations to make VS Code work in Che smoothly:

  • auto-install the recommended extensions
  • idled DevWorkspace detection (in progress)
  • the white-labeling capabilities
@azatsarynnyy azatsarynnyy added kind/epic A long-lived, PM-driven feature request. Must include a checklist of items that must be completed. kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P1 Has a major impact to usage or development of the system. team/editors area/doc Issues related to documentation labels Nov 23, 2022
@l0rd
Copy link
Contributor

l0rd commented Nov 24, 2022

added the helper extension to interact with DevWorkspace. It may be used by the custom extensions which need to work with DevWorkspace directly

Is the helper related to the vscode handler? The handler is not required to inject information about the IDE in the tooling container anymore (see container contributions epic) so I am wondering if we can remove it completly from che-code repo (and add a subtask to #21736) or if we still need it.

@azatsarynnyy
Copy link
Member Author

Is the helper related to the vscode handler?

@l0rd it isn't related to a DevWorkspace handler, but it's mostly to simplify fetching some information from a DevWorksapce. Probably, something not worth documenting, as it's more internal stuff.

As for getting rid of the Che-Code DevWorkspace handler, I've just filed

I believe we do not need a dedicated issue for Che-Theia's DevWorkspace handler, as it will be part of

@max-cx
Copy link

max-cx commented Nov 25, 2022

@azatsarynnyy and @l0rd, how would you compare the expected docs content between the VS Code and the IntelliJ editors (like for any editor Che supports)? I mean should we be expecting a similar issue with a similar scope of documentation for an IntelliJ editor in the future? Or is this docs focus just on VS Code?

@azatsarynnyy
Copy link
Member Author

@max-cx these docs focus just on VS Code

@l0rd
Copy link
Contributor

l0rd commented Nov 25, 2022

@max-cx these docs focus just on VS Code

ok, these are just for VS Code. But we have worked on similar features (such as devfile command support) for JetBrains IDE and we should document that.

@azatsarynnyy
Copy link
Member Author

@max-cx these docs focus just on VS Code

ok, these are just for VS Code. But we have worked on similar features (such as devfile command support) for JetBrains IDE and we should document that.

okay, then here's the corresponding issue for the IDEA editor:

@bdwyertech
Copy link

bdwyertech commented Dec 9, 2022

Is there still a concept of directly specifying plugins like theia had via .che/che-theia-plugins.yaml attribute? I do not see any of that logic in the devworkspace-handler for che-code.

schemaVersion: 2.1.0
attributes:
  .che/che-theia-plugins.yaml: |
    - repository:
        url: 'https://github.com/chef/vscode-chef'
        revision: 2.1.0
      extension: https://github.com/bdwyertech/vscode-chef/releases/download/che/chef-software.Chef-2.1.0.vsix

@azatsarynnyy
Copy link
Member Author

@bdwyertech you can declare the VS Code extensions in the .vscode/extensions.json file and they will be installed automatically in Che-Code.
E.g.: https://github.com/eclipse-che/che-docs/blob/main/.vscode/extensions.json

@max-cx
Copy link

max-cx commented Mar 1, 2023

I opened RHDEVDOCS-5026 to assign a technical writer when the developers are ready to start preparing more content on this topic.

@che-bot
Copy link
Contributor

che-bot commented Aug 28, 2023

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 28, 2023
@azatsarynnyy
Copy link
Member Author

/remove-lifecycle stale

@che-bot che-bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 28, 2023
@che-bot
Copy link
Contributor

che-bot commented Feb 24, 2024

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 24, 2024
@che-bot che-bot closed this as completed Mar 2, 2024
@azatsarynnyy azatsarynnyy reopened this May 3, 2024
@che-bot che-bot closed this as completed May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/doc Issues related to documentation kind/epic A long-lived, PM-driven feature request. Must include a checklist of items that must be completed. kind/task Internal things, technical debt, and to-do tasks to be performed. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Development

No branches or pull requests

6 participants