Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release Che 7.24.2 #18792

Closed
4 of 12 tasks
mkuznyetsov opened this issue Jan 13, 2021 · 10 comments
Closed
4 of 12 tasks

release Che 7.24.2 #18792

mkuznyetsov opened this issue Jan 13, 2021 · 10 comments
Labels
kind/release Issue dedicated to a release (content, status, related PR, go/nogo/problem discussion, etc.)

Comments

@mkuznyetsov
Copy link
Contributor

mkuznyetsov commented Jan 13, 2021

List of pending issues / PRs

Release status

In series, the following will be released via che-release:

  • che-theia, che-machine-exec, che-devfile registry,
  • che-plugin-registry (once che-theia and machine-exec are done)
  • che-parent, che-dashboard, che-workspace-loader, and che (server assembly), including release to Maven Central
  • che-operator

Then, these steps will be done, which still require some manual intervention (PR verification is not yet automated):

  • generation of OperatorHub PRs
  • chectl
  • che-theia, che-machine-exec, che-devfile-registry, che-plugin-registry
  • che-parent, che-dashboard, che-workspace-loader, che
  • che-operator (depends on all of the above)
  • chectl (depends on che-operator)
  • Che community operator PRs (depends on che-operator)

If this is a .0 release:

Owner Process Script CI Artifact(s) + Container(s)
@mkuznyetsov che-theia cico_release.sh centos eclipse/che-theia
@mkuznyetsov che-machine-exec cico_release.sh centos eclipse/che-machine-exec
@mkuznyetsov che-devfile-registry make-release.sh GH action eclipse/che-devfile-registry
@mkuznyetsov che-plugin-registry make-release.sh GH action eclipse/che-plugin-registry
@mkuznyetsov che-parent make-release.sh centos che-parent
@mkuznyetsov che-dashboard make-release.sh GH action che-dashboard
@mkuznyetsov che-workspace-loader make-release.sh GH action che-workspace-loader
@mkuznyetsov che cico_release.sh centos che.core,
eclipse/che-server,
eclipse/che-endpoint-watcher,
eclipse/che-keycloak,
eclipse/che-postgres,
eclipse/che-server,
eclipse/che-e2e
@mkuznyetsov che-operator make-release.sh GH action eclipse/che-operator
@mkuznyetsov chectl make-release.sh GH action chectl releases
@mkuznyetsov mkuznyetsov added the kind/release Issue dedicated to a release (content, status, related PR, go/nogo/problem discussion, etc.) label Jan 13, 2021
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Jan 13, 2021
@nickboldt nickboldt removed the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Jan 13, 2021
@nickboldt
Copy link
Contributor

nickboldt commented Jan 13, 2021

che-theia, che-machine-exec, che-devfile-registry done.

https://github.com/eclipse/che-plugin-registry/actions?query=workflow%3A%22Release+Che+Plugin+Registry%22 shows plugin reg 7.24.2 hasn't released yet

So I've kicked the action again, skipping Phase 1 (theia/machineexec and devfile reg):

https://github.com/eclipse/che-release/runs/1697606270?check_suite_focus=true

@nickboldt
Copy link
Contributor

Houston, we have a problem:

image

and yet:

https://quay.io/repository/eclipse/che-machine-exec?tag=7.24.2&tab=tags

image

@ibuziuk
Copy link
Member

ibuziuk commented Jan 15, 2021

could you clarify when the artifacts will be available on central - https://mvnrepository.com/artifact/org.eclipse.che/che-server ?

@nickboldt
Copy link
Contributor

nickboldt commented Jan 18, 2021

I see che-dashboard, che-workspace-loader images in quay for 7.24.2

But https://mvnrepository.com/artifact/org.eclipse.che/che-server has only 7.24.0 and 7.24.1 artifacts - no 7.24.2 yet. @mkuznyetsov can you report on status there?

@nickboldt
Copy link
Contributor

nickboldt commented Jan 18, 2021

Could be that these are the reasons why nothing was pushed to nexus for che-server 7.24.2:

[INFO] Che Core :: API :: Workspace ....................... FAILURE [  1.021 s]

[ERROR] Failed to execute goal com.coveo:fmt-maven-plugin:2.5.1:check (default) on project che-core-api-workspace: Execution default of goal com.coveo:fmt-maven-plugin:2.5.1:check failed: Index 34 out of bounds for length 33 -> [Help 1]

...

[INFO] Che Legacy E2E :: Test ............................. FAILURE [14:54 min]

[ERROR] Failed to execute goal org.sonatype.plugins:nexus-staging-maven-plugin:1.6.7:deploy (default-deploy) on project che-selenium-test: Execution default-deploy of goal org.sonatype.plugins:nexus-staging-maven-plugin:1.6.7:deploy failed: Staging rules failure! -> [Help 1]

-- https://ci.centos.org/job/devtools-che-release-che-release/263/consoleFull

And here's a possible fix for next time:

eclipse-che/che-release#19

@mkuznyetsov
Copy link
Contributor Author

hm, we have che-server image built with 7.24.2 server, and che-operator was tested against it. And now we merged the release PR for che-operator, which have digests pointed to this image. So should we rebuild the 7.24.2 image, since we're gonna build from new commits? Or should we scrap 7.24.2 and move on to 7.24.3?

@nickboldt
Copy link
Contributor

image

Assuming a re-release of 7.24.2 che-server works, and we don't have to then re-release che-operator / chectl too, then we might be OK with a patched release.

But if it fails, we might as well skip over to 7.24.3 so it's a full end-to-end clean release.

@mkuznyetsov
Copy link
Contributor Author

@ibuziuk 7.24.2 artifacts are now available,

@mkuznyetsov
Copy link
Contributor Author

community-operator PRs are generated

@nickboldt
Copy link
Contributor

community PRs merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/release Issue dedicated to a release (content, status, related PR, go/nogo/problem discussion, etc.)
Projects
None yet
Development

No branches or pull requests

4 participants