Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Find way to distinguish between Docker for Mac and Windows #1744

Closed
TylerJewell opened this issue Jul 15, 2016 · 1 comment
Closed

Find way to distinguish between Docker for Mac and Windows #1744

TylerJewell opened this issue Jul 15, 2016 · 1 comment
Labels
kind/enhancement A feature request - must adhere to the feature request template.

Comments

@TylerJewell
Copy link

In the new Che launcher, which is a Docker container, there are certain scenarios where we need to know if we are using Docker for Windows or Docker for Mac. It influences whether we share a hostname or an IP address to the user. @l0rd
@TylerJewell TylerJewell mentioned this issue Jul 15, 2016
Merged
@bmicklea bmicklea mentioned this issue Jul 15, 2016
Open
20 tasks
@l0rd l0rd mentioned this issue Jul 15, 2016
Closed
5 tasks
@TylerJewell
Copy link
Author

Added in PR #1683. Close this issue when that PR is merged. We did a crude implementation and just check for known docker for windows IP address of hyperv.

@ghost ghost added the kind/enhancement A feature request - must adhere to the feature request template. label Jul 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/enhancement A feature request - must adhere to the feature request template.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@TylerJewell