Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing the statement that external db requires external keycloak setup #1283

Closed
wants to merge 1 commit into from

Conversation

ibuziuk
Copy link
Member

@ibuziuk ibuziuk commented May 26, 2020

What does this PR do?

Removing the statement that external db requires external keycloak setup

What issues does this PR fix or reference?

N/A

Specify the version of the product this PR applies to.

7.x

@ibuziuk
Copy link
Member Author

ibuziuk commented May 26, 2020

@tolusha @davidfestal could you please review?

@dmytro-ndp
Copy link
Contributor

@ibuziuk: it's not possible to install CRW 2.1 (based on Eclipse Che 7.9.x) with external DB and provided identity provider. I am curious If it is now possible to do in newer versions of Eclipse Che.

@ibuziuk
Copy link
Member Author

ibuziuk commented May 26, 2020

well, if it is the case I do not understand how come DB and keycloak are related? If it is true and external db require external keycloak for some reason this should be well documented and explained

@ibuziuk
Copy link
Member Author

ibuziuk commented Jun 2, 2020

@davidfestal could you please comment?

@yhontyk
Copy link

yhontyk commented Jun 24, 2020

@ibuziuk @dmytro-ndp @davidfestal any updates on this PR?
Should I merge it or should we keep the sentence and add more documentation about it?

@ibuziuk
Copy link
Member Author

ibuziuk commented Jun 29, 2020

Related issue - eclipse-che/che#17274
I believe merging this PR is blocked by the issue above ^

@ibuziuk
Copy link
Member Author

ibuziuk commented Jul 29, 2020

Closing in favour of #1430

@ibuziuk ibuziuk closed this Jul 29, 2020
@themr0c themr0c deleted the ibuziuk-patch-1 branch October 26, 2020 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants