Hide "Factories" menu item in sidenav bar #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Docker image build succeeded: docker.io/maxura/che-server:che-dashboard-pull-108 |
olexii4
approved these changes
Nov 20, 2020
sleshchenko
approved these changes
Nov 20, 2020
monaka
pushed a commit
to PizzaFactory/che-dashboard
that referenced
this pull request
Nov 21, 2020
monaka
pushed a commit
to PizzaFactory/che-dashboard
that referenced
this pull request
Nov 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Even though "Factories" menu item in left navigation bar is disabled, this PR updates the branding configuration to disable this menu item in downstream projects as well because persistent factories are based on workspace config and currently this feature doesn't work.
However, factory loading flow
/f?url=still works.What issues does this PR fix or reference?
https://issues.redhat.com/browse/CRW-1383