Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for seat-adjuster example #85

Merged
merged 8 commits into from
Jun 12, 2023
Merged

Conversation

BjoernAtBosch
Copy link
Member

@BjoernAtBosch BjoernAtBosch commented Jun 7, 2023

Describe your changes

Issue ticket number and link

Checklist - Manual tasks

  • Examples are executing successfully
  • Created/updated unit tests. Code Coverage percentage on new code shall be >= 80%.
  • Created/updated integration tests.
  • Devcontainer can be opened successfully
  • Devcontainer can be opened successfully behind a corporate proxy
  • Devcontainer can be re-built successfully
  • Extended the documentation (e.g. README.md, CONTRIBUTING.md, Velocitas)

@BjoernAtBosch BjoernAtBosch requested review from doosuu and MP91 June 7, 2023 13:18
@BjoernAtBosch BjoernAtBosch changed the title Fix/dont use index based access Fixes for seat-adjuster example Jun 7, 2023
@BjoernAtBosch BjoernAtBosch force-pushed the fix/dont_use_index-based_access branch from 8d91eb2 to 54249b8 Compare June 8, 2023 11:45
Copy link
Member

@doosuu doosuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

examples/seat-adjuster/Dockerfile Show resolved Hide resolved
examples/seat-adjuster/Dockerfile Show resolved Hide resolved
Copy link
Contributor

@kse3hi kse3hi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BjoernAtBosch BjoernAtBosch merged commit 0655c67 into main Jun 12, 2023
@BjoernAtBosch BjoernAtBosch deleted the fix/dont_use_index-based_access branch June 12, 2023 09:31
@MP91 MP91 mentioned this pull request Jun 13, 2023
1 task
@kse3hi kse3hi linked an issue Jun 28, 2023 that may be closed by this pull request
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Seat Adjuster Dockerfile is not buildable "stand-alone"
4 participants