Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adjust exceptionhandling for encryption #185

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

Phil91
Copy link
Member

@Phil91 Phil91 commented Jun 25, 2024

Description

Exception-handling was added to the CryptoHelper to properly map the System-exceptions that are thrown by the Aes-classes to Configuration resp. ConflictExceptions

Why

To handle the exceptions thrown by the cryptoHandler to handle the failing process steps correctly

Issue

N/A

Checklist

  • I have followed the contributing guidelines
  • I have performed IP checks for added or updated 3rd party libraries
  • I have created and linked IP issues or requested their creation by a committer
  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have added tests that prove my changes work
  • I have checked that new and existing tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas
  • I have added copyright and license headers, footers (for .md files) or files (for images)

@Phil91 Phil91 requested review from evegufy and ntruchsess June 25, 2024 09:04
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
76.5% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@evegufy
Copy link
Contributor

evegufy commented Jul 11, 2024

Quality Gate Failed Quality Gate failed

Failed conditions 76.5% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

test coverage results will be ignored as they appear to be faulty: supposedly 12 changed lines without coverage - at the same time sonar shows it as if the new lines are all covered...

@evegufy evegufy merged commit 6dcf2f5 into release/v1.1.0-rc.1 Jul 11, 2024
9 of 10 checks passed
@evegufy evegufy deleted the bugfix/encryption branch July 11, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants