Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CoAP causes build issues #728

Closed
danielpeintner opened this issue Mar 31, 2022 · 6 comments · Fixed by #744
Closed

CoAP causes build issues #728

danielpeintner opened this issue Mar 31, 2022 · 6 comments · Fixed by #744
Labels
binding-coap Issues related to coap protocol binding

Comments

@danielpeintner
Copy link
Member

In #727 I wanted to update all version numbers from 0.8.0 to 0.8.1.

Doing so I removed package-lock.json file and recreated it calling npm install.
Unfortunately this caused issues in binding-coap.

I wonder also why we use out-dated libraries.
e.g., "node-coap-client": "1.0.8" vs "node-coap-client": "2.0.2"

@JKRhb do you have a clue why this issue is happening?

grafik

@danielpeintner danielpeintner added the binding-coap Issues related to coap protocol binding label Mar 31, 2022
@JKRhb
Copy link
Member

JKRhb commented Mar 31, 2022

Oh, I think this is probably caused by the fact that @types/bl is only declared as a devDependency and not as a dependency :/ I will open a PR for that in node-coap

@JKRhb
Copy link
Member

JKRhb commented Mar 31, 2022

I opened coapjs/node-coap#333, I hope that will fix the issue.

@danielpeintner
Copy link
Member Author

danielpeintner commented Mar 31, 2022

I added those types as devDependencies for the time being
see 897d3dd

I think doing so should remove the issue...

We should remove them again if the root cause is resolved.

@danielpeintner
Copy link
Member Author

I reverted 897d3dd and updated to 1.0.5 but I get new issues in coap-server-test.ts

@danielpeintner
Copy link
Member Author

FYI, I see

  1) CoAP server implementation
       should read property:
     Uncaught TypeError: Cannot read properties of null (reading 'formIndex')
      at ExposedThing.handleUnobserveProperty (C:\Projects\WoT\thingweb\thingweb.node-wot-danielpeintner\packages\core\src\exposed-thing.ts:1277:25)
      at ObserveWriteStream.<anonymous> (src\coap-server.ts:369:43)

OR

  2) CoAP server implementation
       should read property:
     done() called multiple times in test <CoAP server implementation should read property> of file C:\Projects\WoT\thingweb\thingweb.node-wot-danielpeintner\packages\binding-coap\test\coap-server-test.ts; in addition, done() received error: AssertionError: expected '' to equal '"testValue"'
    at CoapServerTest.<anonymous> (C:\Projects\WoT\thingweb\thingweb.node-wot-danielpeintner\packages\binding-coap\test\coap-server-test.ts:68:82)

@JKRhb
Copy link
Member

JKRhb commented Apr 19, 2022

It took me a while, but I found the issue that caused the strange behavior in node-coap version 1.0.5 (the observe option was always set) and opened coapjs/node-coap#337 to finally fix it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
binding-coap Issues related to coap protocol binding
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants