Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

monaco: fuzzy matching no longer works #9851

Closed
vince-fugnitto opened this issue Aug 5, 2021 · 3 comments · Fixed by #9928
Closed

monaco: fuzzy matching no longer works #9851

vince-fugnitto opened this issue Aug 5, 2021 · 3 comments · Fixed by #9928
Labels
bug bugs found in the application monaco issues related to monaco

Comments

@vince-fugnitto
Copy link
Member

Bug Description:

Following #9154, fuzzy searching is broken in the quick-input or quick-service.

Steps to Reproduce:

  1. start the application with theia as a workspace folder.
  2. use F1 to trigger the quick-commands
  3. search for ag - notice that only results that have exactly ag as a substring are present.
fuzzy.mp4

The following is valid with fuzzy:

C(a)lls: Show Out(g)oing Calls
@vince-fugnitto vince-fugnitto added bug bugs found in the application monaco issues related to monaco labels Aug 5, 2021
@vince-fugnitto
Copy link
Member Author

The fuzzy searching works properly by default (verified in the playground) so something seems wrong with the upgrade.

@EstherPerelman
Copy link
Contributor

Hi @vince-fugnitto, may I ask you (as you authored #9928) to update the filterItems function to fix the next problem (focus on the bold letters),
this causes the search order to be unsorted because it put down items that need to be upper:
on theia:
theia run

on vscode:
vscode run

@vince-fugnitto
Copy link
Member Author

may I ask you (as you authored #9928) to update the filterItems function to fix the next problem (focus on the bold letters).

@EstherPerelman I don't plan on revisiting the search at this time, if you have an improvement then please go ahead. The use-case you described is also not so critical, the result still displays it is just that fuzzy matching is more eager than matching the whole word, and results are still sorted (alphabetically).

this causes the search order to be unsorted because it put down items that need to be upper.

The search order for commands is always alphabetical, the fuzzy just helps us match results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bugs found in the application monaco issues related to monaco
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants