Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuring tasks are broken #9365

Open
RomanNikitenko opened this issue Apr 16, 2021 · 6 comments
Open

Configuring tasks are broken #9365

RomanNikitenko opened this issue Apr 16, 2021 · 6 comments
Labels
bug bugs found in the application tasks issues related to the task system vscode issues related to VSCode compatibility

Comments

@RomanNikitenko
Copy link
Contributor

RomanNikitenko commented Apr 16, 2021

Bug Description:

There are several problems related to configuring tasks:

  1. There are extra fields in the tasks.json file for a configuration after applying Configure Task action for a detected task
    I took the same typescript task for VS Code and for Theia, please compare:

VS Code
config_vs_code

Theia
theia_config

  1. There is a duplicate in the list of tasks for running for a detected task after applying Configure Task action, I don't see such behavior for VS Code
    Theia:
    configure_duplicate

  2. It looks like after configuring a task the configuration from tasks.json file is not taken into account at all - so a user select a configured configuration for running, but the corresponding detected configuration is used instead.

theia_config_bug

  1. Theia allows to edit some fields for a detected task after configuring, but VS Code doesn't. For example, command field for a typescript task.

  2. Type is not displayed for tasks items, so it's hard to recognize - if it's a typescript task or npm, for example.
    I created a separate issue for that earlier: Task type is not displayed for detected tasks #9341

Steps to Reproduce:

  1. Apply a Configure Task action for a detected task.
  2. Try to edit a configuration and run it.
  3. You can use Task: Clear History to be sure that you run a configuration from detected or configured section
  4. Please see my screenshots and shot videos above.

Additional Information

  • Operating System: Fedora
  • Theia Version: ab5fef4
@RomanNikitenko RomanNikitenko added bug bugs found in the application tasks issues related to the task system vscode issues related to VSCode compatibility labels Apr 16, 2021
@RomanNikitenko
Copy link
Contributor Author

Using git reset I checked that it's a regression after merging #9189.
So, reviewing the changes provided by #9189 should help to find the cause of the problems...

@vince-fugnitto
Copy link
Member

@RomanNikitenko should we think about possibly reverting #9189, it seems to have caused multiple issues related to tasks, for example I am unable to run any task anymore from my example plugin:

I verified the commit before works (221d90e).

@RomanNikitenko
Copy link
Contributor Author

I'm +1 for reverting that changes as there are multiple regressions and I'm not able to help with fixing soon...

@RomanNikitenko
Copy link
Contributor Author

should be fixed by #9377
@tsmaeder

@tsmaeder
Copy link
Contributor

@RomanNikitenko at least the first issue is fixed. Could you please open separate issues for the many problems in this issue? Having one issue for many problems makes it very hard to track what is fixed and what is not.

@RomanNikitenko
Copy link
Contributor Author

it's a regression after merging #9189.
that's why I created one issue.
I'm not sure that I should create many issues - first we should check - maybe they were fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bugs found in the application tasks issues related to the task system vscode issues related to VSCode compatibility
Projects
None yet
Development

No branches or pull requests

3 participants