Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tasks: properly type task.taskType? #9357

Closed
paul-marechal opened this issue Apr 14, 2021 · 4 comments
Closed

tasks: properly type task.taskType? #9357

paul-marechal opened this issue Apr 14, 2021 · 4 comments
Labels
enhancement issues that are enhancements to current functionality - nice to haves help wanted issues meant to be picked up, require help quality issues related to code and application quality tasks issues related to the task system

Comments

@paul-marechal
Copy link
Member

Follow up on #9352

#9189 refactored some interfaces, and something like taskType seems to have a use in our system, but it is left out of the new interfaces now for some reason.

It's rather confusing to use this field since we can't rely on typing to understand where it is set, if set at all...
@paul-marechal paul-marechal added enhancement issues that are enhancements to current functionality - nice to haves help wanted issues meant to be picked up, require help tasks issues related to the task system quality issues related to code and application quality labels Apr 14, 2021
@tsmaeder
Copy link
Contributor

I think this is a duplicate of #9333: what we call "taskType" is really selecting the execution engine, but everywhere else, we should use the contributed type.

@paul-marechal
Copy link
Member Author

Agreed! But until this field is refactored away I think I'd keep this issue opened. I'll keep an eye on #9333.

@tsmaeder
Copy link
Contributor

@paul-marechal TaskDto.taskType is now typed as taskType?: 'shell' | 'process' | 'customExecution'. Does that satisfy you?

@paul-marechal
Copy link
Member Author

I am satisfied.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement issues that are enhancements to current functionality - nice to haves help wanted issues meant to be picked up, require help quality issues related to code and application quality tasks issues related to the task system
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tsmaeder @paul-marechal